lkml.org 
[lkml]   [2007]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets
    On Fri, 16 Nov 2007 02:28:09 +0100 (CET) Roman Zippel wrote:

    > Hi,
    >
    > On Thu, 15 Nov 2007, Sam Ravnborg wrote:
    >
    > > You suggest just to check ARCH value and not apply your patch. This was
    > > not my initial understanding as was hopefully obvious from my reply.
    >
    > This patch only adds some extra features.
    >
    > > If user did NOT specify ARCH we should use the kernel configuration - which
    > > your solution fail to do.
    >
    > To make this easy I attached the patch which reverts the problematic
    > changes and then you only need this simple change to force the 64BIT value
    > for ARCH={i386,x86_64}, otherwise it's set by the user:

    Roman,

    This all began (AFAIK) because some of us want to continue to be
    able to specify ARCH={i386,x86_64} on the (make) command line --
    not by using a .config file. Taking away ARCH= on the command line
    is a regression (in some minds, at least), so Sam provided that
    capability. Is that capability still present after this patch?

    Thanks.


    > bye, Roman
    >
    > Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
    >
    > ---
    > Makefile | 3 ++-
    > arch/x86/Kconfig | 4 ++--
    > 2 files changed, 4 insertions(+), 3 deletions(-)
    >
    > Index: linux-2.6/Makefile
    > ===================================================================
    > --- linux-2.6.orig/Makefile
    > +++ linux-2.6/Makefile
    > @@ -165,7 +165,8 @@ export srctree objtree VPATH TOPDIR
    > # then ARCH is assigned, getting whatever value it gets normally, and
    > # SUBARCH is subsequently ignored.
    >
    > -SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
    > +SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
    > + -e s/sun4u/sparc64/ \
    > -e s/arm.*/arm/ -e s/sa110/arm/ \
    > -e s/s390x/s390/ -e s/parisc64/parisc/ \
    > -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
    > Index: linux-2.6/arch/x86/Kconfig
    > ===================================================================
    > --- linux-2.6.orig/arch/x86/Kconfig
    > +++ linux-2.6/arch/x86/Kconfig
    > @@ -3,8 +3,8 @@ mainmenu "Linux Kernel Configuration for
    >
    > # Select 32 or 64 bit
    > config 64BIT
    > - bool "64-bit kernel"
    > - default n
    > + bool "64-bit kernel" if ARCH="x86"
    > + default ARCH="x86_64"
    > help
    > Say yes to build a 64-bit kernel - formerly known as x86_64
    > Say no to build a 32-bit kernel - formerly known as i386


    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-16 04:47    [W:0.024 / U:0.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site