Messages in this thread | | | Date | Thu, 15 Nov 2007 02:59:40 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Fix boot problem with iSeries lacking hugepage support |
| |
On Thu, 15 Nov 2007 10:52:38 +0000 mel@skynet.ie (Mel Gorman) wrote:
> > Shouldn't this have been HUGETLB_PAGE_ORDER? > > > > As a #define, possibly but as a static inline - definitly not. > > In this context, the define is not used because set_pageblock_order() > is a no-op when CONFIG_HUGETLB_PAGE_SIZE_VARIABLE is unset. > pageblock_default_order() is only defined for symmetry as set_pageblock_order() > is defined in both contexts. However, as a #define it might make more sense > to a casual reader to see HUGETLB_PAGE_ORDER even if it has no effect. I > can send a version of the patch that does this with a comment explaining > what is going on with set_pageblock_order() if you like. > > However, in a follow-up fix, you make pageblock_default_order() a static > inline. If it tries to return HUGETLB_PAGE_ORDER, it will fail to compile > when CONFIG_HUGETLB_PAGE is not set. > > Which would you prefer?
Don't care really. Something which is fixed up ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |