Messages in this thread | | | Date | Tue, 13 Nov 2007 21:09:26 -0800 (PST) | Subject | Re: [PATCH] powerpc: Fix fs_enet module build | From | David Miller <> |
| |
From: Jochen Friedrich <jochen@scram.de> Date: Tue, 13 Nov 2007 19:32:08 +0100
> If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms > mii-fec/mii-bitbang should be build as module, as well. On other > platforms, mii-fec/mii-bitbang must be included into the main module. > Otherwise some symbols remain undefined. Additionally, fs_enet uses > libphy, so add a select PHYLIB. > > Building modules, stage 2. > MODPOST 5 modules > ERROR: "fs_scc_ops" [drivers/net/fs_enet/fs_enet.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Signed-off-by: Jochen Friedrich <jochen@scram.de>
This is truly ugly and creates an unnecessarily hard to maintain and complex driver.
Please find a way to fix this for real, so that the PPC_CPM_NEW_BINDING ifdef is not necessary at all and things get built modular or not naturally as we handle things for other cases like this.
THanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |