[lkml]   [2007]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch/rfc 1/4] GPIO implementation framework
    On Tuesday 13 November 2007, eric miao wrote:
    > Here comes a bunch of patches to illustrate my idea, some are not related to
    > the point I mentioned, and they are not mature for now :-)
    > Subject: [PATCH 1/5] add gpio_is_onchip() for commonly used gpio range checking

    I'll send substantive comments later, but meanwhile note
    that the *CURRENT* version was posted last Friday:

    Plus the appended tweak. It's more useful to send patches
    against current code, so applying them doesn't provide a
    small avalanche of rejects. :)

    With respect to this patch adding gpio_is_onchip(), I
    don't see a point. The "gpio >= chip->base" check
    is basically "are the data structures corrupted?" and
    so it should only be done if "extra_checks" is defined.
    (And IMO, not then ...) And combining the other two tests
    that way doesn't make anything more clear to me. That's
    somewhat of a style issue, I guess, unless you're like
    me and don't much trust GCC to avoid extra instructions.

    - Dave

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-11-14 04:27    [W:0.020 / U:63.560 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site