Messages in this thread | | | Date | Tue, 13 Nov 2007 16:34:58 -0500 (EST) | From | "Robert P. J. Day" <> | Subject | Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h |
| |
On Tue, 13 Nov 2007, Julia Lawall wrote:
> Send to: > khali@linux-fr.org, > i2c@lm-sensors.org, > linux-kernel@vger.kernel.org, > kernel-janitors@vger.kernel.org > > Subject: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h > > > ------------------------------------------------------ > > From: Julia Lawall <julia@diku.dk> > > Drop #include <linux/moduleparam.h> in files that also include #include > <linux/module.h>. module.h includes moduleparam.h already.
i'm not convinced that's a good idea. while module.h does currently (and unfortunately) include moduleparam.h, there may come a day when those header files are refactored to actually make sense, at which point all those missing moduleparam.h inclusions will cause all sorts of bad things to happen.
rday
p.s. i tried that cleanup once. it got ugly in a hurry.
-- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://crashcourse.ca ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |