Messages in this thread | | | Date | Tue, 13 Nov 2007 07:28:23 +0300 | From | "Cyrill Gorcunov" <> | Subject | Re: [PATCH 1/1] [IA32-EMU] Remove trailing spaces |
| |
The patch is just an addition to second one. So if you dont like it - just drop it, if it do conflict with other patches - just drop it. That simple :) what is the benefit of removing spaces? "try to keep your code clean" i've read somwhere...
On 11/13/07, Andi Kleen <ak@suse.de> wrote: > On Monday 12 November 2007 23:59:21 David Miller wrote: > > From: Andi Kleen <ak@suse.de> > > Date: Mon, 12 Nov 2007 23:55:54 +0100 > > > > > Sure, it's likely not your time that will be wasted. > > > > I have to respin in excess of 800 networking patches at a time due to > > these kinds of things. It's absolutely trivial, whether by hand > > or using tool options that help you with this kind of task. > > Sure, but what benefit did it have? > > Could you have done something more useful in the time you needed to > write the scripts for that? > > Also it's not only my time -- there are a lot of people who have x86 > patches. e.g. if 20 people have patches and they need half an hour > each to write and test and apply scripts for that we're talking about more > than a man-day overall wasted. > > > Suck it up Andi. > > Well it just seems a dumb thing to do and I like to complain about dumb > things. > Sorry that you are more generous about wasting other people's time. > > The end white space tends to disappear over time anyways because > it is filtered out on everything new, but bulk changing it on old > unchanged code is not a good idea. > > -Andi (who will shut up because he's approaching the half hour limit > for such silly topics. At least it was only me and you though, not 20 > people) > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |