lkml.org 
[lkml]   [2007]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] sysfs: fix off-by-one error in fill_read_buffer
on 2007-11-12 22:08 Tejun Heo wrote:
> It isn't strictly a bug. If the ->show() op fills full PAGE_SIZE and
> returns PAGE_SIZE, the user will get full PAGE_SIZE bytes correctly, so
> it will work. However, considering normal use cases, return value of
> PAGE_SIZE very likely indicates an error condition, so considering it a
> BUG condition is a good idea.
>
> Miao, can you please note that the code works fine with PAGE_SIZE return
> but it's likely to indicate truncated result or overflow in normal use
> cases as a comment on top of the BUG_ON()?
>
> Thanks.

OK, I did it.

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>

---
fs/sysfs/file.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 27d1785..7f6a8d2 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -119,7 +119,9 @@ static int fill_read_buffer(struct dentry * dentry, struct sysfs_buffer * buffer

sysfs_put_active_two(attr_sd);

- BUG_ON(count > (ssize_t)PAGE_SIZE);
+ /* the code works fine with PAGE_SIZE return but it's likely to
+ indicate truncated result or overflow in normal use cases. */
+ BUG_ON(count >= (ssize_t)PAGE_SIZE);
if (count >= 0) {
buffer->needs_read_fill = 0;
buffer->count = count;
--
1.5.3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-13 04:53    [W:0.042 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site