lkml.org 
[lkml]   [2007]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")
On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote:
> Andrew,
>
> I'm getting minor warnings when applying two patches from
> <http://userweb.kernel.org/~akpm/mmotm/>
>
> It's probably not serious but I wonder if checkpatch catches this.
>
> Applying patch..git-net.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.
>
> Applying patch..mnt_unbindable-fix.patch
> Warning: commit message does not conform to UTF-8.
> You may want to amend it after fixing the message, or set the config
> variable i18n.commitencoding to the encoding your project uses.

We do have checks for UTF-8. The commit message problems are usually real
names in Signed-off-by:s being "complex" and being in their email locale
not UTF-8. It is a problem area for sure as people want their email to
look right in their email to the list, and yet they need it in UTF-8 for git.

Yeah it looks like we pick it up ok, the message could do with a little
love:

apw@pinky$ ~/git/checkpatch/checkpatch.pl -q --no-tree ./git-net.patch
ERROR: Invalid UTF-8
#229:
This is based on a patch by Vicenç Beltran Querol.

ERROR: Invalid UTF-8
#398:
by Toralf Förster:

ERROR: Invalid UTF-8
#773:
Signed-off-by: Lutz Preßler <Lutz.Pressler@SerNet.DE>

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-12 10:05    [W:0.152 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site