lkml.org 
[lkml]   [2007]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 13/13] Char: nozomi, cleanup read and write
    On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote:
    >...
    > --- a/drivers/char/nozomi.c
    > +++ b/drivers/char/nozomi.c
    >...
    > - if (size_bytes - i == 2) {
    > + if (unlikely(size_bytes - i == 2)) {
    >...

    Please don't add likely/unlikely in drivers unless it brings a
    measurable improvement.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-10 17:17    [W:0.019 / U:1.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site