lkml.org 
[lkml]   [2007]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC 9/13] Char: nozomi, lock cleanup
    Date
    On Samstag 10 November 2007 00:48:52, you (Jiri Slaby) wrote:
    > nozomi, lock cleanup
    >
    > - semaphore is deprecated, use mutex instead
    > - don't return -ERESTARTSYS when signal might not be pending since it's not
    > permitted (unknown retval mioght reach userspace)
    > - don't lock interruptible in close or the card might not be stopped on last
    > close

    Good catches. But i had to change it a bit, especially the mutex_trylock.
    From mutex.c: "..it is negated to the down_trylock() return values!
    Be careful about this when converting semaphores to mutexes." ;-)
    Now it works again (doesn't deadlock my card anymore).

    Thanks,
    Frank
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-10 16:47    [W:0.024 / U:2.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site