Messages in this thread Patch in this message | | | Date | Sun, 11 Nov 2007 09:55:10 +0530 | From | Kamalesh Babulal <> | Subject | Re: [PATCH] [POWERPC] Fix CONFIG_SMP=n build error on ppc64 |
| |
On Sat, Nov 10, 2007 at 02:59:29PM -0600, Olof Johansson wrote: > [POWERPC] Fix CONFIG_SMP=n build error > > The patch "KVM: fix !SMP build error" change the way smp_call_function() > actually uses the passed in function names on non-SMP builds. So > previously it was never caught that the function passed in was never > actually defined. > > This causes a build error on ppc64_defconfig + CONFIG_SMP=n: > > arch/powerpc/mm/tlb_64.c: In function 'pgtable_free_now': > arch/powerpc/mm/tlb_64.c:71: error: 'pte_free_smp_sync' undeclared (first use in this function) > arch/powerpc/mm/tlb_64.c:71: error: (Each undeclared identifier is reported only once > arch/powerpc/mm/tlb_64.c:71: error: for each function it appears in.) > > So we need to define it even if CONFIG_SMP is off. Either that or ifdef > out the smp_call_function() call, but that's ugly. Hi,
Thanks, the patch fixes the build failure.
Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/arch/powerpc/mm/tlb_64.c b/arch/powerpc/mm/tlb_64.c index eafbca5..e2d867c 100644 --- a/arch/powerpc/mm/tlb_64.c +++ b/arch/powerpc/mm/tlb_64.c @@ -54,12 +54,10 @@ unsigned long pte_freelist_forced_free; ((PAGE_SIZE - sizeof(struct pte_freelist_batch)) \ / sizeof(pgtable_free_t))
-#ifdef CONFIG_SMP static void pte_free_smp_sync(void *arg) { /* Do nothing, just ensure we sync with all CPUs */ } -#endif
/* This is only called when we are critically out of memory * (and fail to get a page in pte_free_tlb). -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |