lkml.org 
[lkml]   [2007]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RT] fix rt-task scheduling issue
    From
    Date
    Hi Guys,
    Nice find! Comment inline..

    (adding linux-rt-users)

    for reference to

    http://lkml.org/lkml/2007/10/8/252

    On Mon, 2007-10-08 at 22:46 -0400, Steven Rostedt wrote:
    > Index: linux-2.6.23-rc9-rt2/kernel/sched.c
    > ===================================================================
    > --- linux-2.6.23-rc9-rt2.orig/kernel/sched.c
    > +++ linux-2.6.23-rc9-rt2/kernel/sched.c
    > @@ -2207,7 +2207,7 @@ static inline void finish_task_switch(st
    > * If we pushed an RT task off the runqueue,
    > * then kick other CPUs, they might run it:
    > */
    > - if (unlikely(rt_task(current) && prev->se.on_rq && rt_task(prev))) {
    > + if (unlikely(rt_task(current) && rq->rt_nr_running > 1)) {
    > schedstat_inc(rq, rto_schedule);
    > smp_send_reschedule_allbutself_cpumask(current->cpus_allowed);

    the current->cpus_allowed I think probably should have been
    "prev->cpus_allowed" in the original code? However, in light of the new
    findings with this bug Mike found, this should probably be sent to
    allbutself() without the mask since you don't know what could have been
    queued behind you.

    Unless I am missing something?

    Regards,
    -Greg


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-09 06:23    [W:0.043 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site