Messages in this thread | | | Date | Tue, 09 Oct 2007 11:29:20 -0400 | From | James Smart <> | Subject | Re: [PATCH] aic94xx: Use request_firmware() to provide SAS address if the adapter lacks one |
| |
Why do you prefer request_firmware() vs something over sysfs ?
Does environments like the kdump kernel also have access to data needed by request_firmware() ?
-- james s
Andrew Vasquez wrote: > On Mon, 08 Oct 2007, Darrick J. Wong wrote: > >> On Mon, Oct 08, 2007 at 03:48:32PM -0700, Andrew Vasquez wrote: >> >>> So how about factoring that out to a transport-level interface. How >>> about something along the lines of the following patch, whereby the >>> software driver upon detecting no valid WWPN, makes an upcall to each >>> interface's 'request_wwn()'. The data passed in from shost_gendev >>> should be enough for some helper script to cull relevent device bits >>> and perhaps offer some level of persistence... Off base? >> Hrm... jejb made a remark that it might be better to pass the >> scsi_host's device into request_firmware() as your example does, so I'll >> pitch in a patch to do likewise with libsas--the scsi_host knows the >> actual device it's coming from, and userland can sort that all out later >> anyway via DEVPATH. >> >> I suppose one could also have multiple scsi_hosts per PCI device, which >> means that my first patch would stumble horribly in more than a few >> cases. > > This is done already in the FC case -- NPIV. Though with that > interface, the administrator is already responsible for assigning > proper WWNN/WWPN during creation. > >>> Darrick, forgive the FC example, I don't do SAS... >> That's ok, I don't do FC. :) Looks mostly good to me... > > -- > av > - > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |