lkml.org 
[lkml]   [2007]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH]fix page release issue in filemap_fault
From
Date
On Mon, 2007-10-08 at 23:28 +0800, Yan Zheng wrote:
> Hi all
>
> find_lock_page increases page's usage count, we should decrease it
> before return VM_FAULT_SIGBUS
>
> Signed-off-by: Yan Zheng<yanzheng@21cn.com>

Nice catch, .23 material?

Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

> ----
> diff -ur linux-2.6.23-rc9/mm/filemap.c linux/mm/filemap.c
> --- linux-2.6.23-rc9/mm/filemap.c 2007-10-07 15:03:33.000000000 +0800
> +++ linux/mm/filemap.c 2007-10-08 23:14:39.000000000 +0800
> @@ -1388,6 +1388,7 @@
> size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
> if (unlikely(vmf->pgoff >= size)) {
> unlock_page(page);
> + page_cache_release(page);
> goto outside_data_content;
> }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-08 19:17    [W:0.027 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site