Messages in this thread | | | Date | Sat, 6 Oct 2007 12:10:21 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH] vc bell config |
| |
On Oct 5 2007 17:00, Andrew Morton wrote: >> >> It is already possible to deactivate the vc bell on a per-tty basis, >> by using echo -en "\e[11;0]", but this is reset on reset(1). >> >> This adds a sysfs parameter to globally control the vc bell, as well >> as sysfs parameters for default pitch and duration. > >Why do we need this? To fix the stupid-app-makes-my-box-beep problem, I >guess. Is there no other way of suppressing the beep?
The user has a number of choices: - rmmod pcspkr, to disable all beeps (including X) - vt.bell_enabled=0, to disable beeps on all VCs, but not X - vt.default_bell_pitch=400, to give VC the frequency used in X (400 is perceived less penetrant than 750)
>> * Here is the default bell parameters: 750HZ, 1/8th of a second >> */ >> -#define DEFAULT_BELL_PITCH 750 >> -#define DEFAULT_BELL_DURATION (HZ/8) >> +static unsigned int default_bell_pitch = 750; >> +static unsigned int default_bell_duration = HZ / 8; > >It is inapt to call these default_X. Because once they have been altered >by the user, they aren't defaults any more.
They are still default, as in: they will define the initial pitch/duration when a tty is created, or when the tty is reset.
If they were just 'bell_pitch', one culd assume that changing it changes the pitch of all ttys, which it does not. Whether it's good or not that the vc subsytem has per-tty pitches is a different story.
Well, that's what I am thinking about it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |