lkml.org 
[lkml]   [2007]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: On text size and run time if config is "n", [PATCH 2/2] Colored kernel output (run3)

    On Oct 7 2007 00:28, Oleg Verych wrote:
    >
    >I thought, i was talking about *write() functions, that got one
    >additional unrelated, non config removable API change in face of
    >`unsigned int loglevel'.

    Documentation/stable_api_nonsense.txt ;-)

    >Idea. Extend those macro defines before format string with one
    >additional macro, that will be empty, if config is NO and having
    >colour byte otherwise.
    >
    >In the *write() functions, have
    >
    > color = str[0];
    > ++str;

    This is just as "bad" as the loglevel parameter. Because you'd have
    to parse str[0] in _every_ write() function. Furthermore, the string
    that is being printed also goes to klogd/syslog, including the <N>
    tag already. If you now add a color byte in the KERN_* macros, then
    that color byte would also go to syslog. Not good.

    >Sorry, i don't know much about stuff, you've presented:

    (Paraphrased one paragraph above.)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-07 00:23    [W:0.031 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site