Messages in this thread | | | From | Andreas Schwab <> | Subject | Re: [PATCH 1/1] unify DMA_..BIT_MASK definitions: v3.1 | Date | Fri, 05 Oct 2007 23:24:25 +0200 |
| |
"Robert P. J. Day" <rpjday@mindspring.com> writes:
> On Fri, 5 Oct 2007, Andrew Morton wrote: > >> -#define DMA_BIT_MASK(n) ((1ULL<<(n))-1) >> +#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) > > or you could take advantage of the macros in kernel.h and write that > as: > > +#define DMA_BIT_MASK(n) (((n) == 64) ? ULLONG_MAX : ((1ULL<<(n))-1))
#define DMA_BIT_MASK(n) ((u64)-1 >> (64 - (n)))
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |