lkml.org 
[lkml]   [2007]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: -rt scheduling: wakeup bug?

    * Mike Kravetz <kravetz@us.ibm.com> wrote:

    > > if (rq->curr && p && rq && _need_resched())
    > > trace_special_pid(p->pid, PRIO(p), PRIO(rq->curr));
    >
    > Not an issue with the patch, just that last bit of code pulled in for
    > context. I don't think it is a bug, but the checking of 'rq' after
    > checking 'rq->curr' just doesn't look right (or necessary). Could it
    > just be an artifact from earlier versions of the code?

    yeah, you are right - and rq shouldnt ever be NULL there anyway.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-04 10:05    [W:3.621 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site