lkml.org 
[lkml]   [2007]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH]: exit_ivtv_i2c() cannot be __devexit
Date
On Wednesday 31 October 2007 05:23, David Miller wrote:
> Please apply, thanks!
>
> [MEDIA] IVTV: exit_ivtv_i2c() cannot be __devexit
>
> It is referenced both from __devinit code (ivtv_probe) and
> normal .text (ivtv_process_eeprom), and therefore cannot
> be discarded via __devexit.

Good catch!

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

Thanks,

Hans

>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> drivers/media/video/ivtv/ivtv-i2c.c | 2 +-
> drivers/media/video/ivtv/ivtv-i2c.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/ivtv/ivtv-i2c.c
> b/drivers/media/video/ivtv/ivtv-i2c.c index 285fca6..623eea2 100644
> --- a/drivers/media/video/ivtv/ivtv-i2c.c
> +++ b/drivers/media/video/ivtv/ivtv-i2c.c
> @@ -741,7 +741,7 @@ int __devinit init_ivtv_i2c(struct ivtv *itv)
> return i2c_bit_add_bus(&itv->i2c_adap);
> }
>
> -void __devexit exit_ivtv_i2c(struct ivtv *itv)
> +void exit_ivtv_i2c(struct ivtv *itv)
> {
> IVTV_DEBUG_I2C("i2c exit\n");
>
> diff --git a/drivers/media/video/ivtv/ivtv-i2c.h
> b/drivers/media/video/ivtv/ivtv-i2c.h index 677c329..de6a074 100644
> --- a/drivers/media/video/ivtv/ivtv-i2c.h
> +++ b/drivers/media/video/ivtv/ivtv-i2c.h
> @@ -36,6 +36,6 @@ void ivtv_call_i2c_clients(struct ivtv *itv,
> unsigned int cmd, void *arg);
>
> /* init + register i2c algo-bit adapter */
> int __devinit init_ivtv_i2c(struct ivtv *itv);
> -void __devexit exit_ivtv_i2c(struct ivtv *itv);
> +void exit_ivtv_i2c(struct ivtv *itv);
>
> #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-31 09:19    [from the cache]
©2003-2011 Jasper Spaans