Messages in this thread | | | Date | Wed, 31 Oct 2007 15:34:22 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] af_key: suppress a warning for 64k pages. |
| |
On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > > I'm not so sure ifdef'ing things up all over the place is the way to > solve this. It makes the code ultra ugly.
I agree.
> I think we should retain the check, but modify it so that GCC knows we > understand that it's OK if it is always false. Perhaps a simple (u32) > cast on the left branch of the comparison is sufficient?
Unfortunately, that does not suppress the warning (gcc is getting too smart :-().
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [unhandled content-type:application/pgp-signature] | |