Messages in this thread | | | Subject | Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services | From | "Huang, Ying" <> | Date | Wed, 31 Oct 2007 08:47:47 +0800 |
| |
On Tue, 2007-10-30 at 15:58 +0000, Denys Vlasenko wrote: > On Tuesday 30 October 2007 05:55, Huang, Ying wrote: > > +static inline unsigned long native_get_wallclock(void) > > +{ > > + unsigned long retval; > > + > > + if (efi_enabled) > > + retval = efi_get_time(); > > + else > > + retval = mach_get_cmos_time(); > > + > > + return retval; > > +} > > mach_get_cmos_time() is itself an inline, and a _large_ one > (~20 LOC with macro and function calls). > > efi_get_time() is an inline too, although strange one: > it is declared inline *only* in efi.c file: > inline unsigned long efi_get_time(void) > (yes, just inline, not static/extern), > while efi.h has normal extern for it: > extern unsigned long efi_get_time(void); > > Is it supposed to be like that?
efi_get_time is no longer inline in this patch. See efi.c of this patch.
Best Regards, Huang Ying - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |