Messages in this thread | | | Date | Tue, 30 Oct 2007 08:22:40 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names |
| |
On Tue, 30 Oct 2007 09:56:53 +0000 Christoph Hellwig wrote:
> On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote: > > +/** > > + * vfs_ioctl - call filesystem specific ioctl methods > > + * > > + * @filp: [in] open file to invoke ioctl method on > > + * @cmd: [in] ioctl command to execute > > + * @arg: [in/out] command-specific argument for ioctl > > I've never seen these in/out annotations and doubt they're valid in > kerneldoc. Randy?
They are just treated as part of the parameter explanation text. I don't see any problem with them.
> > + * Invokes filesystem specific ->unlock_ioctl, if one exists; otherwise > > unlocked_ioctl
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |