lkml.org 
[lkml]   [2007]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names
On Tue, 30 Oct 2007 09:56:53 +0000 Christoph Hellwig wrote:

> On Sun, Oct 28, 2007 at 08:40:56PM -0400, Erez Zadok wrote:
> > +/**
> > + * vfs_ioctl - call filesystem specific ioctl methods
> > + *
> > + * @filp: [in] open file to invoke ioctl method on
> > + * @cmd: [in] ioctl command to execute
> > + * @arg: [in/out] command-specific argument for ioctl
>
> I've never seen these in/out annotations and doubt they're valid in
> kerneldoc. Randy?

They are just treated as part of the parameter explanation text.
I don't see any problem with them.

> > + * Invokes filesystem specific ->unlock_ioctl, if one exists; otherwise
>
> unlocked_ioctl


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-30 16:25    [W:0.093 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site