[lkml]   [2007]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH resend] Make the dev_*() family of macros in device.hcomplete
Hi Greg K-H,

> > +#define dev_info(dev, format, arg...) \
> > + dev_printk(KERN_INFO, dev, format, ## arg)
> > +
> > #ifdef DEBUG
> > #define dev_dbg(dev, format, arg...) \
> > - dev_printk(KERN_DEBUG , dev , format , ## arg)
> > + dev_printk(KERN_DEBUG, dev, format, ## arg)
> Those extra spaces are there for a good reason, older versions of gcc
> are broken without it. So please, put them all back...

You mean I should add spaces before commas only where they were
initially or to all new code and/or macros? I've observed other kernel
code and more often there are no spaces before commas. I'm asking
because the CodingStyle document is not very explicit about this rule.

Thank you,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-10-30 13:13    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean