[lkml]   [2007]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: vm_ops.page_mkwrite() fails with vmalloc on 2.6.23
    On 10/29/07, Peter Zijlstra <> wrote:
    > On Mon, 2007-10-29 at 01:17 -0700, Jaya Kumar wrote:
    > > An aside, I just tested that deferred IO works fine on
    > >
    > > I understood from the thread that PeterZ is looking into page_mkclean
    > > changes which I guess went into 2.6.23. I'm also happy to help in any
    > > way if the way we're doing fb_defio needs to change.
    > OK, seems I can't read. Or at least, I missed a large part of the
    > problem.
    > page_mkclean() hasn't changed, it was ->page_mkwrite() that changed. And
    > looking at the fb_defio code, I'm not sure I understand how its
    > page_mkclean() use could ever have worked.
    > The proposed patch [1] only fixes the issue of ->page_mkwrite() on
    > vmalloc()'ed memory. Not page_mkclean(), and that has never worked from
    > what I can make of it.
    > Jaya, could you shed some light on this? I presume you had your display
    > working.

    I thought I had it working. I saw the display update after each
    mmap/write sequence to the framebuffer. I need to check if there's an
    munmap or anything else going on in between write sequences that would
    cause it to behave like page_mkclean was working.

    Is it correct to assume that page_mkclean should mark the pages
    read-only so that the next write would again trigger mkwrite? Even if
    the page was from a vmalloc_to_page()?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-10-29 18:55    [W:0.023 / U:39.260 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site