lkml.org 
[lkml]   [2007]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [lm-sensors] hwmon/f75375s.c: buggy if()
    Hi:

    * Riku Voipio <riku.voipio@iki.fi> [2007-10-26 14:14:23 +0300]:
    > On Fri, Oct 26, 2007 at 10:36:47AM +0200, Jean Delvare wrote:
    > > Patch looks correct, however it doesn't apply on top of Mark's tree. I
    > > was able to get it to apply by reverting "(f75375s) fix pwm mode
    > > setting" first, but then the build fails. Presumably the other f75375s
    > > patches interact badly. Can you please respin this patch on top of
    > > Mark's tree (i.e. on top the the 4 other f75375s patches you sent since
    > > the -rc1 merge)? Thanks.
    >
    > The surrounding code had wandered to another function, so it's suprising
    > it applied at all. Here's respin.
    >
    > --
    > "rm -rf" only sounds scary if you don't have backups

    > >From 4de69e3ab5b5833cddb503f0dcb2a3ccc2d5b328 Mon Sep 17 00:00:00 2001
    > From: Riku Voipio <riku.voipio@movial.fi>
    > Date: Fri, 26 Oct 2007 13:53:50 +0300
    > Subject: [PATCH] hwmon (f75375s) fix buggy if() properly
    >
    > Fix value check in set_pwm_mode(). Instead of checking for
    > chip variant there, make pwmX_mode sysfs nodes only writable
    > on f75375 variant.
    >
    > Signed-off-by: Riku Voipio <riku.voipio@movial.fi>
    > ---
    > drivers/hwmon/f75375s.c | 19 ++++++++++++++++---
    > 1 files changed, 16 insertions(+), 3 deletions(-)
    >

    Applied to hwmon-2.6.git/testing, thanks.

    --
    Mark M. Hoffman
    mhoffman@lightlink.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-28 18:41    [W:0.022 / U:33.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site