lkml.org 
[lkml]   [2007]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usbserial: fix inconsistent lock state
On Sun, 28 Oct 2007, Borislav Petkov wrote:

> ---
> In commit acd2a847e7fee7df11817f67dba75a2802793e5d usb_serial_generic_write()
> disables interrupts when taking &port->lock which is also taken in
> usb_serial_generic_read_bulk_callback() resulting in an inconsistent lock state
> due to the latter not disabling interrupts on the local cpu. Fix that by
> disabling interrupts in the latter call site also.
> Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>

You are right, I missed the usb_serial_generic_read_bulk_callback() one,
thanks for catching this.

Acked-by: Jiri Kosina <jkosina@suse.cz>

--
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-28 15:47    [W:0.034 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site