lkml.org 
[lkml]   [2007]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 08/10] SLUB: Optional fast path using cmpxchg_local
    On Sun, 28 Oct 2007, Pekka J Enberg wrote:

    > - local_irq_restore(flags);
    > + object = do_slab_alloc(s, c, gfpflags, node, addr);
    > + if (unlikely(!object))
    > + goto out;

    Undoing the optimization that one of the earlier patches added.

    The #ifdef version is for me at least easier to read. The code there is a
    special unit that has to deal with the most performance critical piece of
    the slab allocator. And the #ifdef there clarifies that any changes have
    to be done to both branches.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-29 04:37    [W:0.028 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site