Messages in this thread | | | Date | Mon, 29 Oct 2007 12:56:43 +1000 | From | Greg Ungerer <> | Subject | Re: [M68KNOMMU]: new style ColdFire UART driver |
| |
Hi Andrew,
Andrew Morton wrote: > On Fri, 19 Oct 2007 11:42:41 +1000 > Greg Ungerer <gerg@snapgear.com> wrote: > >> A new style serial driver for the Freescale ColdFire UART to replace >> the old style one currently in the tree (drivers/serial/mcfserial.c). >> >> Currently this UART is only found in the ColdFire CPU family of parts >> (thus I prefixed this patch [M68KNOMMU]). >> >> This has been around for a long while now, tested on all available >> platforms. >> >> ... >> > > All of these: > >> +/****************************************************************************/ > > don't really add much value. > >> +static unsigned int mcf_get_mctrl(struct uart_port *port) >> +{ >> + struct mcf_uart *pp = (struct mcf_uart *) port; > > container_of() would be nicer: it explains what's going on and removes the > unpleasing requirement that uart_port be the first member of mcf_uart. > >> +static void mcf_set_mctrl(struct uart_port *port, unsigned int sigs) >> +{ >> + struct mcf_uart *pp = (struct mcf_uart *) port; > > Many instances..
Ok, I'll change those over to container_of().
>> +static void mcf_set_termios(struct uart_port *port, struct ktermios *termios, >> + struct ktermios *old) >> +{ >> + unsigned long flags; >> + unsigned int baud, baudclk; >> + unsigned char mr1, mr2; > > Is this all up-to-date with Alan's recent termios changes?
As far as I can tell, yes.
>> +static struct mcf_uart mcf_ports[3]; >> + >> +#define MCF_MAXPORTS (sizeof(mcf_ports) / sizeof(struct mcf_uart)) > > Use ARRAY_SIZE here.
Yep, I'll change that.
>> +/****************************************************************************/ >> +#if defined(CONFIG_SERIAL_MCF_CONSOLE) >> +/****************************************************************************/ >> + >> +int __init early_mcf_setup(struct mcf_platform_uart *platp) > > hrm, this is global and has no callers. > >> +{ >> + struct uart_port *port; >> + int i; >> + >> + for (i = 0; ((i < MCF_MAXPORTS) && (platp[i].mapbase)); i++) { >> + port = &mcf_ports[i].port; >> + >> + port->line = i; >> + port->type = PORT_MCF; >> + port->mapbase = platp[i].mapbase; >> + port->membase = (platp[i].membase) ? platp[i].membase : >> + (unsigned char __iomem *) port->mapbase; >> + port->iotype = SERIAL_IO_MEM; >> + port->irq = platp[i].irq; >> + port->uartclk = MCF_BUSCLK; >> + port->flags = ASYNC_BOOT_AUTOCONF; >> + port->ops = &mcf_uart_ops; >> + } >> + >> + return 0; >> +} >> +
It is intended to be used by ColdFire platforms that want early boot console support. The old driver (drivers/serial/mcfserial.c) sort of gave you this for free with its fixed resourcing. I have changes to the ColdFire based m68knommu systems to use a platform model at init, and this is used there.
Thanks.
Regards Greg
------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com Secure Computing Corporation PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |