lkml.org 
[lkml]   [2007]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c
    In message <20071028141222.GA29323@infradead.org>, Christoph Hellwig writes:
    > Nice, I always hated these double-indented switch statements.
    >
    > > + case FIBMAP:
    > > + {
    > > + struct address_space *mapping = filp->f_mapping;
    > > + int res;
    > > + /* do we support this mess? */
    > > + if (!mapping->a_ops->bmap)
    > > + return -EINVAL;
    > > + if (!capable(CAP_SYS_RAWIO))
    > > + return -EPERM;
    > > + error = get_user(block, p);
    > > + if (error)
    > > + return error;
    > > + lock_kernel();
    > > + res = mapping->a_ops->bmap(mapping, block);
    > > + unlock_kernel();
    > > + return put_user(res, p);
    >
    > While you're at it, it's probably worth splitting this out into
    > a small helper function.

    Sure. I assume you mean an internal function to encapsulate the entire case
    statement's code, one for each of the FIO* cases.

    Erez.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-28 19:09    [W:0.021 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site