Messages in this thread | | | Date | Sat, 27 Oct 2007 16:18:42 +0200 | From | Adrian Bunk <> | Subject | jffs2_init_acl_post() can return uninitialized variable |
| |
Commit cfc8dc6f6f69ede939e09c2af06a01adee577285 added the following function that can return the value of an uninitialized variable:
<-- snip -->
... int jffs2_init_acl_post(struct inode *inode) { struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode); int rc;
if (f->i_acl_default) { rc = __jffs2_set_acl(inode, JFFS2_XPREFIX_ACL_DEFAULT, f->i_acl_default); if (rc) return rc; }
if (f->i_acl_access) { rc = __jffs2_set_acl(inode, JFFS2_XPREFIX_ACL_ACCESS, f->i_acl_access); if (rc) return rc; }
return rc; } ...
<-- snip -->
Spotted by the Coverity checker.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |