Messages in this thread | | | Date | Sat, 27 Oct 2007 07:40:29 +0100 | From | Al Viro <> | Subject | Re: [PATCH] DMAENGINE: too many kref_put calls |
| |
On Fri, Oct 26, 2007 at 04:56:48PM -0700, Shannon Nelson wrote:
> static void dma_dev_release(struct device *dev) > { > - struct dma_chan *chan = to_dma_chan(dev); > - kref_put(&chan->device->refcount, dma_async_device_cleanup); > + return; > }
Practically guaranteed to be broken. Empty ->release() is almost certain to mean that you can get operations on already freed object. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |