Messages in this thread |  | | Date | Sat, 27 Oct 2007 23:22:31 +0200 (CEST) | | From | Roman Zippel <> | | Subject | Re: [PATCH 1/2] irq_flags_t: intro and core annotations |
| |
Hi,
On Sun, 28 Oct 2007, Alexey Dobriyan wrote:
> > If it's just about the type checking, something like below should pretty > > much do the same. > > It won't catch, the following if both variables are unsigned long: > > spin_lock_irqsave(&lock, flags); > [stuff] > spin_unlock_irqrestore(&lock, foo->flags); > > It won't catch "static unsigned long flags;". With sparse, we can > eventually mark type as "on-stack only".
It should be on the stack, but we have cases where a pointer to it is used (e.g. lock_timer_base). How do you want to deal with this?
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |