[lkml]   [2007]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [AppArmor 32/45] Enable LSM hooks to distinguish operations on file descriptors from operations on pathnames
    On Fri, Oct 26, 2007 at 01:30:52PM +0200, Miklos Szeredi wrote:
    > On Thu, 2007-10-25 at 23:40 -0700, wrote:
    > > plain text document attachment (file-handle-ops.diff)
    > > Struct iattr already contains ia_file since commit cc4e69de from
    > > Miklos (which is related to commit befc649c). Use this to pass
    > > struct file down the setattr hooks. This allows LSMs to distinguish
    > > operations on file descriptors from operations on paths.
    > There's a slight problem (other than HCH not liking it) with this
    > approach of passing the open file in iattr: for special files, the
    > struct file pointer makes no sense to the filesystem, since it is always
    > opened by the generic functions.

    > This wasn't a problem with ftruncate(), because that one only works on
    > regular files, but fchmod/fchown/futimes will work on special files as
    > well, and the filesystem interpreting file->private_data could cause
    > nasty bugs.
    > So I think the correct solution (which was suggested by Trond and
    > others) is to define an f_op->fsetattr() method, which interested
    > filesystems can define.
    yeah that does sound like the way to go, thank Miklos

    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2007-10-26 20:51    [W:0.020 / U:11.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site