lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ata: ahci: Enable enclosure management via LED (resend)
On Thu, 25 Oct 2007 23:35:11 +0200
Ingo Oeser <ioe-lkml@rameria.de> wrote:

> Hi Kristen,
>
> On Thursday 25 October 2007, Kristen Carlson Accardi wrote:
> > Enable enclosure management via LED
> >
> > As described in the AHCI spec, some AHCI controllers may support
> > Enclosure management via a variety of protocols. This patch
> > adds support for the LED message type that is specified in
> > AHCI 1.1 and higher.
>
> Linux has a LED subsystem for that. May I suggest, that you just register
> these leds and let userspace handle them via that via the LED API?
>
> The LED userspace API is described in Documentation/leds-class.txt
> and the headers for registering LEDs is linux/leds.h under include/
>
> Since you explicitly WANT user space to control these, that should
> be the right API.
>
> Richard, what do YOU think?
>
>
> Best Regards
>
> Ingo Oeser
>

I did look into using the LED class for this, but it didn't appropriate
as I wanted the leds to be associated with a particular disk, and not
with the platform as a whole. It seemed to me that the led_class was
a bit of overkill for what we needed to do here, since we just need
on/off and nothing else.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-25 23:53    [from the cache]
©2003-2011 Jasper Spaans