lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.
    David Miller wrote:
    > The forthcoming patches are also available from:
    >
    > kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git
    >
    > and clean up the handling of the common quirk wherein setting
    > INTX_DISABLE will mistakedly disable MSI generation for some
    > devices.
    >
    > For devices without that problem, we want to keep the pci_intx() calls
    > in drivers/pci/msi.c because those help protect against devices
    > with the opposite problem. Such devices always generate INTX
    > interrupts even when MSI is enabled, unless INTX_DISABLE is set.
    >
    > Michael, please pay special attention to patch #3. I think I
    > picked the correct PCI device IDs to match for the quirk
    > (5714* and 5780*) but it's possible we might need more elaborate
    > checks here. It at least worked properly for the chips in my
    > Niagara system.
    >
    > In addition to the Tigon3 cases, I added quirk entries for the
    > SB700/800 SATA chips and the IXP SB400 USB controllers.
    >
    > Signed-off-by: David S. Miller <davem@davemloft.net>

    I'm happy with this patch series. A quirk is better than a
    sledgehammer, and MSI-mode SATA is better than INTX-mode SATA :)

    Jeff



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-25 07:41    [W:5.191 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site