Messages in this thread | | | Date | Thu, 25 Oct 2007 18:09:49 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support |
| |
On Thu, 25 Oct 2007, Huang, Ying wrote:
> This patch adds basic runtime services support for EFI x86_64 > system. The main file of the patch is the addition of efi.c for > x86_64. This file is modeled after the EFI IA32 avatar.
modeled means copied and modified, right?
This is wrong. I compared efi_32.c and efi_64.c and a large amount of the code is simply the same. The small details can be sorted out by two sets of macros/inline functions easily.
Please fix this up.
> EFI runtime > services initialization are implemented in efi.c. Some x86_64 > specifics are worth noting here. On x86_64, parameters passed to UEFI > firmware services need to follow the UEFI calling convention. For this > purpose, a set of functions named lin2win<x> (<x> is the number of > parameters) are implemented. EFI function calls are wrapped before > calling the firmware service.
Why needs this to be called lin2win? We do not call Windows, we call EFI services, so please use a naming convention which is related to the functionality of the code.
> + * > + * Function calling ABI conversion from SYSV to Windows for x86_64
Again, these are wrappers to access EFI and not Windows.
tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |