lkml.org 
[lkml]   [2007]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] blackfin: "extern inline" -> "static inline"
    On 10/24/07, H. Peter Anvin <hpa@zytor.com> wrote:
    > Mike Frysinger wrote:
    > > On 10/24/07, Jie Zhang <jzhang.linux@gmail.com> wrote:
    > >> On 10/25/07, Adrian Bunk <bunk@kernel.org> wrote:
    > >>> "extern inline" will have different semantics with gcc 4.3.
    > >>>
    > >>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
    > >>>
    > >>> --- a/include/asm-blackfin/string.h
    > >>> +++ b/include/asm-blackfin/string.h
    > >>> @@ -4,7 +4,7 @@
    > >>> #ifdef __KERNEL__ /* only set these up for kernel code */
    > >>>
    > >>> #define __HAVE_ARCH_STRCPY
    > >>> -extern inline char *strcpy(char *dest, const char *src)
    > >>> +static inline char *strcpy(char *dest, const char *src)
    > >>> {
    > >>> char *xdest = dest;
    > >>> char temp = 0;
    > >> What if we compile it with gcc 4.1?
    > >
    > > we'll have to either use the gcc attributes to force old inline
    > > behavior or use the gcc flag to force it
    >
    > We should probably have an extern_inline define then, assuming this is a
    > function that does exist in a linkable version already -- otherwise
    > "static inline" is correct.

    right, we do have string versions in arch/blackfin/lib/ and we do want
    the "classical" gcc behavior here with "extern static". an
    extern_inline macro in compiler.h sounds good since
    __attribute__((__gnu_inline__)) doesnt exist in gcc-3.4.x (the other
    version that works for Blackfin other than gcc-4.1.x).

    so i guess NACK this patch since we dont want "static inline" and we
    dont yet support gcc-4.3 on Blackfin.
    -mike
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-25 05:21    [W:0.023 / U:148.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site