Messages in this thread | | | Date | Wed, 24 Oct 2007 16:18:40 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 3/4] sound: Use stringbuf |
| |
At Tue, 23 Oct 2007 17:12:45 -0400, Matthew Wilcox wrote: > > sound/ had its own snd_info_buffer for doing proc reads, which can be > profitably replaced with stringbuf. It actually finds a bug since ->read > and ->write now have a different signature.
Do you mean the assignment of snd_ca0106_proc_reg_write? I also found it out today coindentally :)
Any other bugs I missed?
> @@ -375,7 +375,7 @@ static void snd_ac97_proc_read(struct snd_info_entry *entry, struct snd_info_buf > > #ifdef CONFIG_SND_DEBUG > /* direct register write for debugging */ > -static void snd_ac97_proc_regs_write(struct snd_info_entry *entry, struct snd_info_buffer *buffer) > +static void snd_ac97_proc_regs_write(struct snd_info_entry *entry, struct stringbuf *buffer) > { > struct snd_ac97 *ac97 = entry->private_data; > char line[64];
This shouldn't be changed.
thanks,
Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |