Messages in this thread | | | Date | Tue, 23 Oct 2007 21:05:34 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 2/12] X86: fix nvidia HPET warning |
| |
Jeff Garzik wrote: > arch/x86/kernel/early-quirks.c:40: warning: ‘nvidia_hpet_check’ defined but not used > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com> > --- > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c > index dc34acb..639e632 100644 > --- a/arch/x86/kernel/early-quirks.c > +++ b/arch/x86/kernel/early-quirks.c > @@ -35,12 +35,14 @@ static void __init via_bugs(void) > } > > #ifdef CONFIG_ACPI > +#ifdef CONFIG_X86_IO_APIC >
Why not #if defined(CONFIG_ACPI) && defined(CONFIG_X86_IO_APIC)? Saves a line and a layer of #if(def).
> > static int __init nvidia_hpet_check(struct acpi_table_header *header) > { > return 0; > } > -#endif > +#endif /* CONFIG_X86_IO_APIC */ > +#endif /* CONFIG_ACPI */ >
J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |