Messages in this thread | | | Date | Tue, 23 Oct 2007 10:52:28 +0300 | From | "Pekka Enberg" <> | Subject | Re: [PATCH] Fix warning in mm/slub.c |
| |
Hi,
On 10/23/07, Yasunori Goto <y-goto@jp.fujitsu.com> wrote: > > "Make kmem_cache_node for SLUB on memory online to avoid panic" introduced > > the following: > > > > mm/slub.c:2737: warning: passing argument 1 of 'atomic_read' from > > incompatible pointer type > > > > > > Signed-off-by: Olof Johansson <olof@lixom.net> > > > > > > diff --git a/mm/slub.c b/mm/slub.c > > index aac1dd3..bcdb2c8 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -2734,7 +2734,7 @@ static void slab_mem_offline_callback(void *arg) > > * and offline_pages() function shoudn't call this > > * callback. So, we must fail. > > */ > > - BUG_ON(atomic_read(&n->nr_slabs)); > > + BUG_ON(atomic_long_read(&n->nr_slabs)); > > > > s->node[offline_node] = NULL; > > kmem_cache_free(kmalloc_caches, n); > > > Oops, yes. Thanks. > > Acked-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |