[lkml]   [2007]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] e1000, e1000e valid-addr fixes
    On Tue, Oct 23, 2007 at 08:55:29PM -0400, Jeff Garzik wrote:
    > Actually, looking over the code I see obvious bugs in the logic:
    > An invalid ethernet address should not cause device loading to fail,
    > because the user is given the opportunity to supply a MAC address via
    > userspace (ifconfig or whatever) before the interface goes up.
    > I just created the attached -bug fix- patch as illustration, though I have
    > not committed it, waiting for comment.

    Is there a good reason why we have such checks duplicated in the drivers
    (with every driver doing it differently...) instead of doing it in

    > Jeff



    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-10-24 03:17    [W:0.022 / U:74.296 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site