Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH -v7 1/3] x86 boot: setup data | Date | Wed, 24 Oct 2007 01:18:20 +0200 |
| |
On Wednesday 24 October 2007 00:08:32 Jeremy Fitzhardinge wrote: > Huang, Ying wrote: > > This patch add a field of 64-bit physical pointer to NULL terminated > > single linked list of struct setup_data to real-mode kernel > > header. This is used as a more extensible boot parameters passing > > mechanism. > > > > As a general comment, I can't say I'm thrilled about sticking the copied > setup data at the end of the initial pagetables. This is already a > fairly complex area, and changing it touches a surprisingly large number > of places. I wonder if there isn't a better way to deal with this > (possibly by fixing up the generation of the initial pagetables in the > process).
With the early reserve code in ftp://firstfloor.org/pub/ak/x86_64/quilt/patches/early-reserve and ftp://firstfloor.org/pub/ak/x86_64/quilt/patches/early-alloc this could be likely done cleaner.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |