lkml.org 
[lkml]   [2007]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Intel Manageability Engine Interface driver
    On Tue, 23 Oct 2007 11:04:29 -0400
    lsorense@csclub.uwaterloo.ca (Lennart Sorensen) wrote:

    > On Mon, Oct 22, 2007 at 11:40:01AM -0700, Andrew Morton wrote:
    > > - Here:
    > >
    > > + if (0 == memcmp(&heci_wd_guid,
    > >
    > > we boringly prefer "if (foo == 0)" rather than "if (0 == foo)".
    > > (lots of places).
    >
    > But 0 == blah is safer. If you accidentally do 0 = blah the compiler
    > will tell you.

    gcc will tell you in the other direction just as well.

    and people read from left to right (at least in english) so coding in
    that direction is generally preferred in the Linux kernel as well.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-23 18:29    [W:0.019 / U:31.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site