lkml.org 
[lkml]   [2007]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] unlock 12c_mutex before return
    Date
    Roel Kluin <12o3l@tiscali.nl> writes:

    > unlock 12c_mutex before return -EINVAL
    >
    > Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
    > ---
    > diff --git a/drivers/media/dvb/dvb-usb/au6610.c b/drivers/media/dvb/dvb-usb/au6610.c
    > index 18e0b16..31f47c7 100644
    > --- a/drivers/media/dvb/dvb-usb/au6610.c
    > +++ b/drivers/media/dvb/dvb-usb/au6610.c
    > @@ -82,8 +82,10 @@ static int au6610_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msg[],
    > if (mutex_lock_interruptible(&d->i2c_mutex) < 0)
    > return -EAGAIN;
    >
    > - if (num > 2)
    > + if (num > 2) {
    > + mutex_unlock(&d->i2c_mutex);
    > return -EINVAL;

    How about moving the check before the lock?

    Andreas.

    --
    Andreas Schwab, SuSE Labs, schwab@suse.de
    SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
    PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
    "And now for something completely different."
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-23 11:53    [W:0.021 / U:1.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site