lkml.org 
[lkml]   [2007]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/10] Change table chaining layout


    On Mon, 22 Oct 2007, Alan Cox wrote:

    > For structures, not array elements or stack objects. Does gcc now get
    > aligned correct as an attribute on a stack object ?

    I think m68k stack layout still guarantees 4-byte-alignment, no?

    > Still doesn't answer the rather more important question - why not just
    > stick a NULL on the end instead of all the nutty hacks ?

    You still do need one bit for the discontiguous case, so it's not like you
    can avoid the hacks anyway (unless you just blow up the structure
    entirely) and make it a separate member). So once you have that
    bit+pointer, using a separate NULL entry isn't exactly prettier.

    Especially as we actally want to see the difference between
    "end-of-allocation" and "not yet filled in", so you shouldn't use NULL
    anyway, you should probably use something like "all-ones".

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-22 23:51    [W:6.040 / U:1.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site