lkml.org 
[lkml]   [2007]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] return hidden bug
    Rik van Riel wrote:
    > On Mon, 22 Oct 2007 03:05:05 +0200
    > Roel Kluin <12o3l@tiscali.nl> wrote:
    >
    >> return hidden bug
    >>
    >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
    >>
    >> diff --git a/arch/alpha/kernel/pci_iommu.c
    >> b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644
    >> --- a/arch/alpha/kernel/pci_iommu.c
    >> +++ b/arch/alpha/kernel/pci_iommu.c
    >> @@ -365,8 +365,8 @@ pci_unmap_single(struct pci_dev *pdev, dma_addr_t
    >> dma_addr, size_t size, printk(KERN_ERR "Bogus pci_unmap_single:
    >> dma_addr %lx " " base %lx size %x\n", dma_addr, arena->dma_base,
    >> arena->size);
    >> - return;
    >> BUG();
    >> + return;
    >> }
    >>
    >> npages = calc_npages((dma_addr & ~PAGE_MASK) + size);
    >
    > BUG() will terminate the process that runs into it, so you can
    > just remove the return alltogether. If BUG() is hit, the return
    > will never be reached.
    >
    ---
    hidden bug returns

    Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
    ---
    diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
    index e1c4707..ca55c33 100644
    --- a/arch/alpha/kernel/pci_iommu.c
    +++ b/arch/alpha/kernel/pci_iommu.c
    @@ -365,7 +365,6 @@ pci_unmap_single(struct pci_dev *pdev, dma_addr_t dma_addr, size_t size,
    printk(KERN_ERR "Bogus pci_unmap_single: dma_addr %lx "
    " base %lx size %x\n", dma_addr, arena->dma_base,
    arena->size);
    - return;
    BUG();
    }


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-22 03:57    [W:0.025 / U:32.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site