lkml.org 
[lkml]   [2007]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/17] drivers/input/serio/i8042.c: irq handler clean
Date
Hi Jeff,

On Sunday 21 October 2007, Jeff Garzik wrote:
> commit bdf311215ef8dbae0254c092deaed1d5928b013e
> Author: Jeff Garzik <jeff@garzik.org>
> Date: Fri Oct 19 19:28:54 2007 -0400
>
> drivers/input/serio/i8042.c: irq handler clean
>
> * remove unnecessary prototype
>
> * distinguish between polled and irq-driven event handling
>
> * don't bother worrying about 'irq' function arg

I don't like these 2 changes. When I ask for debug data I really
want to know what interrupt (1 or 12) was raised in response to
a command. Your changes remove this visibility.

>
> * dev_id passed to irq handlers is unused, to change the request_irq()
> argument to NULL
>

Does this really matter?

Thanks.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-21 20:01    [from the cache]
©2003-2011 Jasper Spaans