Messages in this thread | | | Date | Sun, 21 Oct 2007 01:54:18 +0100 | From | Al Viro <> | Subject | Re: [PATCH 1/2] irq_flags_t: intro and core annotations |
| |
On Sun, Oct 21, 2007 at 03:55:46AM +0400, Alexey Dobriyan wrote: > * irq_flags_t is marked with __bitwise__ which means sparse(1) will warn > developer when he accidently uses wrong type or totally wrong variable. > * irq_flags_t allows conversion to struct instead of typedef without flag day. > This will give compile-time breakage of buggy users later. > * irq_flags_t allows arch maintainers to eventually switch to something > smaller than "unsigned long" if they want to.
> P.S.: Anyone checking for differences in sparse logs -- don't panic, > just remove __bitwise__ .
Umm... Could you make that conditional on something, so that it could be done with e.g. -D__CHECK_IRQFLAGS__? We could make that unconditional closer to the end of conversion. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |