lkml.org 
[lkml]   [2007]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read_inode()
    > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
    > index 0079b2c..d8fb795 100644
    > --- a/fs/ext2/inode.c
    > +++ b/fs/ext2/inode.c
    ...
    > +
    > + raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);
    > if (IS_ERR(raw_inode))
    > goto bad_inode;
    Hmm, why don't you use the return value from raw_inode? It can be
    either -EIO or -EINVAL if 'ino' was invalid...
    Otherwise the patch looks fine.

    Honza
    --
    Jan Kara <jack@suse.cz>
    SuSE CR Labs
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-02 12:09    [W:0.021 / U:60.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site