lkml.org 
[lkml]   [2007]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] synchronize_irq needs a barrier
    On Sat, Oct 20, 2007 at 02:02:42AM +0000, Maxim Levitsky wrote:
    >
    > Thus I now understand that .suspend() should do:
    >
    > saa_writel(SAA7134_IRQ1, 0);
    > saa_writel(SAA7134_IRQ2, 0);
    > saa_writel(SAA7134_MAIN_CTRL, 0);
    >
    > dev->insuspend = 1;
    > smp_wmb();

    If we patch synchronize_irq() as discussed here then you can
    use it in place of smp_wmb() and remove the smp_rmb from the
    interrupt handler (the latter is the path that matters).

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-20 05:41    [W:4.079 / U:0.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site